[HDFS-10600] PlanCommand#getThrsholdPercentage should not use throughput value.

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.0, 3.0.0-beta1
• Fix Version/s: 3.0.0-alpha1
• Component/s: diskbalancer
• Target Version/s: 3.0.0-beta1
• Assignee: Yiqun Lin
• Reporter: Lei (Eddy) Xu
• Created: 06/Jul/16 01:12
• Updated: 15/Jul/16 18:00
• Resolved: 14/Jul/16 17:42

Description

In PlanCommand#getThresholdPercentage

 private double getThresholdPercentage(CommandLine cmd) {
....
    if ((value <= 0.0) || (value > 100.0)) {
      value = getConf().getDouble(
          DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT,
          DFSConfigKeys.DFS_DISK_BALANCER_MAX_DISK_THRUPUT_DEFAULT);
    }
    return value;
  }

DISK_THROUGHPUT has the unit of "MB", so it does not make sense to return throughput as a percentage value.

Btw, we should use THROUGHPUT instead of THRUPUT.

Issue Links

• is related to: HDFS-10633 DiskBalancer : Add the description for the new setting dfs.disk.balancer.plan.threshold.percent in HDFSDiskbalancer.md