Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8870

Store.needsCompaction() should include minFilesToCompact

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.95.1
    • 0.98.0, 0.96.0
    • Compaction
    • None

    Description

      read here:

        public boolean needsCompaction() {
          return (storefiles.size() - filesCompacting.size()) > minFilesToCompact;
        }
      

      imho, it should be

        public boolean needsCompaction() {
          return (storefiles.size() - filesCompacting.size()) >= minFilesToCompact;
        }
      

      Attachments

        1. HBASE-8870.03.patch
          8 kB
          Sergey Shelukhin
        2. HBASE-8870.txt
          0.8 kB
          Liang Xie
        3. HBASE-8870.txt
          0.6 kB
          Liang Xie
        4. HBase-8870-v2.txt
          4 kB
          Liang Xie

        Activity

          People

            xieliang007 Liang Xie
            xieliang007 Liang Xie
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: