Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7340

Master coprocessor notification for assignmentManager.balance() is inconsistent

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 0.95.0
    • None
    • None
    • Reviewed

    Description

      I found this issue when reading user discussion which is quoted below.

      In HMaster.moveRegion(), we have:

            this.assignmentManager.balance(rp);
            if (this.cpHost != null) {
              this.cpHost.postMove(hri, rp.getSource(), rp.getDestination());
            }
      

      Meaning, user can register master coprocessor which would receive region movement notification.

      The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification.
      I think we should enhance the following hook (at line 1335) with list of regions moved so that notification from master is consistent:

              this.cpHost.postBalance();
      

      Here is excerpt for user discussion:

      Sometimes user performs compaction after a region is moved (by balancer). We should provide 'hook' which lets user specify what follow-on actions to take after region movement.

      See discussion on user mailing list under the thread 'How to know it's time for a major compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92&subj=How+to+know+it+s+time+for+a+major+compaction+

      Attachments

        1. 7340-v1.txt
          7 kB
          Ted Yu
        2. 7340-v2.txt
          7 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: