Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5330

TestCompactSelection - adding 2 test cases to testCompactionRatio

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      There were three existing assertions in TestCompactSelection testCompactionRatio that did "max # of files" assertions...

          assertEquals(maxFiles,
              store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
      

      ... and for references ...

        assertEquals(maxFiles,
              store.compactSelection(sfCreate(true, 7,6,5,4,3,2,1)).getFilesToCompact().size());
      

      ... but they didn't assert against which StoreFiles got selected. While the number of StoreFiles is the same, the files selected are actually different, and I thought that there should be explicit assertions showing that.

      Attachments

        Issue Links

          Activity

            People

              dmeil Doug Meil
              dmeil Doug Meil
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: