[HBASE-25010] `assert` on allocated buffer sizes before making calls to `Unsafe.copyMemory`

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.3.0
• Component/s: regionserver
• Assignee: Nick Dimiduk
• Reporter: Nick Dimiduk
• Created: 10/Sep/20 20:15
• Updated: 05/Aug/21 17:57

Description

While investigating a SIGSEGV, I stumbled into our use of Unsafe.copyMemory for moving data between byte[]'s and/or DirectByteBuffer's. Calls to copyMemory use an Object, offset API that performs no validation what so ever. I'd like to add assert statements (disabled by default) before these memory copies.

Issue Links

• links to: GitHub Pull Request #2380