[HBASE-24546] CloneSnapshotProcedure unlimited retry

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0, 2.2.5
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.6
• Component/s: snapshots
• Assignee: wenfeiyi666
• Reporter: wenfeiyi666
• Created: 12/Jun/20 06:55
• Updated: 09/Oct/21 07:41
• Resolved: 06/Jul/20 06:13

Description

since regions dir was not remove in the previous execution created, need to be remove when retrying, resulting in exception, unlimited retry

procedure.CloneSnapshotProcedure: Retriable error trying to clone snapshot=snapshot_test to table=test:backup state=CLONE_SNAPSHOT_WRITE_FS_LAYOUT
org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: clone snapshot={ ss=snapshot_test table=test:backup type=FLUSH } failed because A clone should not have regions to remove
        at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:434)
        at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFsLayout(CloneSnapshotProcedure.java:465)
        at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFilesystemLayout(CloneSnapshotProcedure.java:392)
        at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:142)
        at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:67)
        at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194)
        at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962)
        at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1662)
        at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1409)
        at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)
        at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979)
Caused by: java.lang.IllegalArgumentException: A clone should not have regions to remove
        at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
        at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:418)
        ... 10 more

and the cloned regions name are unchanged, resulting in new created regions be removed when retrying

Issue Links

• links to: GitHub Pull Request #1900
• links to: GitHub Pull Request #1916
• links to: GitHub Pull Request #1917