[HBASE-21749] RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.1.0
• Fix Version/s: 3.0.0-alpha-1, 1.5.0, 2.2.0, 2.1.3
• Component/s: Replication, UI
• Hadoop Flags: Reviewed
• Assignee: Nihal Jain
• Reporter: Nihal Jain
• Created: 21/Jan/19 06:38
• Updated: 22/Jan/19 15:16
• Resolved: 22/Jan/19 02:01

Description

Sometimes RS UI is unable to open as we get a NPE; This happens because shipper.getCurrentPath() may return null.

We should have a null check @ ReplicationSource.java#L331 

      Path currentPath = shipper.getCurrentPath();
      try {
        fileSize = getFileSize(currentPath);
      } catch (IOException e) {
        LOG.warn("Ignore the exception as the file size of HLog only affects the web ui", e);
        fileSize = -1;
      }

Issue Links

• relates to: HBASE-20193 Basic Replication Web UI - Regionserver
• relates to: HBASE-21680 Port HBASE-20194 (Basic Replication WebUI - Master) and HBASE-20193 (Basic Replication Web UI - Regionserver) to branch-1