[HBASE-20939] There will be race when we call suspendIfNotReady and then throw ProcedureSuspendedException

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.0.1, 2.2.0, 2.1.1
• Component/s: amv2
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 25/Jul/18 09:00
• Updated: 30/Jul/18 01:44
• Resolved: 27/Jul/18 13:57

Description

This is very typical usage in our procedure implementation, for example, in AssignProcedure, we will call AM.queueAssign and then suspend ourselves to wait until the AM finish processing our assign request.

But there could be races. Think of this:
1. We call suspendIfNotReady on a event, and it returns true so we need to wait.
2. The event has been waked up, and the procedure will be added back to the scheduler.
3. A worker picks up the procedure and finishes it.
4. We finally throw ProcedureSuspendException and the ProcedureExecutor suspend us and store the state in procedure store.

So we have a half done procedure in the procedure store for ever... This may cause assertion when loading procedures. And maybe the worker can not finish the procedure as when suspending we need to restore some state, for example, add something to RootProcedureState. But anyway, it will still lead to assertion or other unexpected errors.

And this can not be done by simply adding a lock in the procedure, as most works are done in the ProcedureExecutor after we throw ProcedureSuspendException.

Issue Links

• is related to: HBASE-18152 [AMv2] Corrupt Procedure WAL file; procedure data stored out of order
• relates to: HBASE-20949 Split/Merge table can be executed concurrently with DisableTableProcedure