[HBASE-19749] Revisit logic of UserScanQueryMatcher#mergeFilterResponse method - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Move

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.0-beta-1
Fix Version/s: 2.0.0-beta-1, 2.0.0
Component/s: None
Labels:
None

Hadoop Flags:

Reviewed

Description

As ~~HBASE-19729~~ comment , there are following points to be optimized:

1. when the number of cells exceed max version in scan, we should return SEEK_NEXT_COL match code, but if current code is INCLUDE_AND_SEEK_NEXT_ROW, we can optimize to choose the max step between SEEK_NEXT_COL and INCLUDE_AND_SEEK_NEXT_ROW, which is SEEK_NEXT_ROW
2. check to call ColumnTracker#doneWithColumn() only when we change the match code to SEEK_NEXT_COL or INCLUDE_AND_SEEK_NEXT_COL because of filterResponse.
3. More UT for those edge case..

https://issues.apache.org/jira/browse/HBASE-19729?focusedCommentId=16318131&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16318131