Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18577

shaded client includes several non-relocated third party dependencies

    XMLWordPrintableJSON

Details

    • Incompatible change
    • Hide
      <!-- markdown -->

      The HBase shaded artifacts (hbase-shaded-client and hbase-shaded-server) no longer contain several non-relocated third party dependency classes that were mistakenly included. Downstream users who relied on these classes being present will need to add a runtime dependency onto an appropriate third party artifact.

      Previously, we erroneously packaged several third party libs without relocating them. In some cases these libraries have now been relocated; in some cases they are no longer included at all.

      Includes:

      * jaxb
      * jetty
      * jersey
      * codahale metrics (HBase 1.4+ only)
      * commons-crypto
      * jets3t
      * junit
      * curator (HBase 1.4+)
      * netty 3 (HBase 1.1)
      * mokito-junit4 (HBase 1.1)

      There is now testing to ensure that the shaded artifacts only contain expected relocated content. It can be run via `mvn -Dtest=noUnitTests -pl hbase-shaded/hbase-shaded-check-invariants -am -Prelease verify`.

      For version 2.0+ this patch removes hadoop-mapreduce-client-core from the set of dependencies included for the hbase-client and hbase-shaded-client artifacts.

      For 2.0+, the slf4j-log4j12 dependency is now optional for both shaded artifacts.
      Show
      <!-- markdown --> The HBase shaded artifacts (hbase-shaded-client and hbase-shaded-server) no longer contain several non-relocated third party dependency classes that were mistakenly included. Downstream users who relied on these classes being present will need to add a runtime dependency onto an appropriate third party artifact. Previously, we erroneously packaged several third party libs without relocating them. In some cases these libraries have now been relocated; in some cases they are no longer included at all. Includes: * jaxb * jetty * jersey * codahale metrics (HBase 1.4+ only) * commons-crypto * jets3t * junit * curator (HBase 1.4+) * netty 3 (HBase 1.1) * mokito-junit4 (HBase 1.1) There is now testing to ensure that the shaded artifacts only contain expected relocated content. It can be run via `mvn -Dtest=noUnitTests -pl hbase-shaded/hbase-shaded-check-invariants -am -Prelease verify`. For version 2.0+ this patch removes hadoop-mapreduce-client-core from the set of dependencies included for the hbase-client and hbase-shaded-client artifacts. For 2.0+, the slf4j-log4j12 dependency is now optional for both shaded artifacts.

    Description

      we have some unexpected unrelocated third party dependencies in our shaded artifacts.

      Attachments

        1. HBASE-18577.6.patch
          25 kB
          Sean Busbey
        2. HBASE-18577.7.patch
          26 kB
          Sean Busbey
        3. HBASE-18577.WIP.0.patch
          18 kB
          Sean Busbey
        4. HBASE-18577.WIP.1.patch
          20 kB
          Sean Busbey
        5. HBASE-18577.WIP.-1.patch
          14 kB
          Sean Busbey
        6. HBASE-18577.WIP.2.patch
          22 kB
          Sean Busbey
        7. HBASE-18577.WIP.3.patch
          25 kB
          Sean Busbey
        8. HBASE-18577.WIP.4.patch
          28 kB
          Sean Busbey
        9. HBASE-18577.WIP.5.patch
          25 kB
          Sean Busbey
        10. HBASE-18577.WIP-branch-1.2.v5.patch
          28 kB
          Sean Busbey
        11. HBASE-18577-branch-1.v6.patch
          28 kB
          Sean Busbey
        12. HBASE-18577-branch-1.v7.patch
          29 kB
          Sean Busbey

        Issue Links

          Activity

            People

              busbey Sean Busbey
              busbey Sean Busbey
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: