Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17654

RSGroup code refactoring

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • rsgroup
    • None

    Description

      • Making rsGroupInfoManager non-static in RSGroupAdminEndpoint
      • Encapsulate RSGroupAdminService into an internal class in RSGroupAdminEndpoint (on need of inheritence).
      • Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted empty implementations.
      • Change two internal classes in RSGroupAdminServer to non-static (so outer classes' variables can be shared).
      • Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in other places). Moved 2 functions to RSGroupManagerImpl because they are only used there.
      • Javadoc comments
      • Improving variable names
      • Maybe other misc refactoring

      Attachments

        1. HBASE-17654.master.001.patch
          109 kB
          Apekshit Sharma
        2. HBASE-17654.master.002.patch
          141 kB
          Apekshit Sharma
        3. HBASE-17654.master.003.patch
          141 kB
          Apekshit Sharma
        4. HBASE-17654.master.004.patch
          141 kB
          Apekshit Sharma
        5. HBASE-17654.master.005.patch
          143 kB
          Apekshit Sharma
        6. HBASE-17654.master.006.patch
          128 kB
          Apekshit Sharma

        Issue Links

          Activity

            People

              appy Apekshit Sharma
              appy Apekshit Sharma
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: