[HBASE-1739] hbase-1683 broke splitting; only split three logs no matter what N was.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.20.0
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 03/Aug/09 23:16
• Updated: 13/Sep/09 22:24
• Resolved: 03/Aug/09 23:23

Description

There's a hard-coding in HLog#splitLog that presumes we always read in batches of ten logs:

Index: src/java/org/apache/hadoop/hbase/regionserver/HLog.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/HLog.java     (revision 799653)
+++ src/java/org/apache/hadoop/hbase/regionserver/HLog.java     (working copy)
@@ -860,7 +860,7 @@
         // Stop at logfiles.length when it's the last step
         int endIndex = step == maxSteps - 1? logfiles.length: 
           step * concurrentLogReads + concurrentLogReads;
-        for (int i = (step * 10); i < endIndex; i++) {
+        for (int i = (step * concurrentLogReads); i < endIndex; i++) {
           // Check for possibly empty file. With appends, currently Hadoop 
           // reports a zero length even if the file has been sync'd. Revisit if
           // HADOOP-4751 is committed.

When I changed it so we default to reading 3 files at a time rather than 10 over in hbase-1683, the hard-coding made it so we didn't read all logs.