Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17239

Add UnsafeByteOperations#wrap(ByteInput, int offset, int len) API

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • Protobufs
    • None
    • Reviewed

    Description

      Instead of exposing the newInstance(ByteInput, boolean) in CIS we could just add a UnsafeByteOperations#wrap(ByteInput, offset, len). And we could just call that and do a #newcodedInput() over that. So internally we do return a immutable version of the ByteInput only. This way we can avoid CIS#newInstance(ByteInput) exposure and can keep it package private as done in COS.

      Attachments

        1. HBASE-17239_V1.patch
          5 kB
          ramkrishna.s.vasudevan
        2. HBASE-17239_V2.patch
          7 kB
          ramkrishna.s.vasudevan
        3. HBASE-17239_V3.patch
          8 kB
          ramkrishna.s.vasudevan
        4. HBASE-17239.addendum.patch
          2 kB
          Michael Stack

        Activity

          People

            ram_krish ramkrishna.s.vasudevan
            ram_krish ramkrishna.s.vasudevan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: