Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-16825 Backup mega patch: Review 52748 work
  3. HBASE-16828

Make backup command-line tool interface consistent

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • backup&restore
    • None
    • Reviewed

    Description

      From Stacks review:

      This is interesting... if I pass a set and a table as command lets me do, it runs the backup twice. I was sort of expecting one backup dir with all content in it. No biggie. Here is the command I ran (the -set included the table so the tool behavior avoids backup overwrite).
      ./hbase/bin/hbase --config ~/conf_hbase backup create full hdfs://ve0524.halxg.cloudera.com:8020/backup clicks -set s

      The command I ran was $ ./hbase/bin/hbase --config ~/conf_hbase backup create full clicks I'm missing the backup location which probably explains the above. I'd think the tool would verify the command before going ahead and running a mapreduce job?

      stack@ve0524:~$ ./hbase/bin/hbase --config ~/conf_hbase backup create

      ... does the tables 'option' not take a hyphen but all others do? Most of the time options are delimited by space but not always....

      When required args are not supplied, dumping help/usage rather than ERROR is usual and user friendly.

      What about consistency in errors, that sometimes commands are single letter, other times words, that descriptions in usage are not what is on the Option, that we do Options but don't use it to do Usage/help, and others.

      Attachments

        1. HBASE-16828-v1.patch
          6 kB
          Vladimir Rodionov
        2. HBASE-16828-v2.patch
          69 kB
          Vladimir Rodionov
        3. HBASE-16828-v3.patch
          69 kB
          Vladimir Rodionov
        4. HBASE-16828-v4.patch
          68 kB
          Vladimir Rodionov
        5. HBASE-16828-v5.patch
          66 kB
          Vladimir Rodionov

        Activity

          People

            vrodionov Vladimir Rodionov
            vrodionov Vladimir Rodionov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: