Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13078

IntegrationTestSendTraceRequests is a noop

    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • None
    • integration tests
    • None
    • Reviewed
    • Test removed from 0.98, 1.0, and 1.1, but left in place on master and branch-1.

    Description

      While pair-debugging with jeffreyz on HBASE-13077, we noticed that IntegrationTestSendTraceRequests doesn't actually assert anything. This test should be converted to use a mini cluster, setup a POJOSpanReceiver, and then verify the spans collected.

      Attachments

        1. HBASE-13078.patch
          23 kB
          Josh Elser
        2. HBASE-13078-0.98-removal.patch
          10 kB
          Josh Elser
        3. HBASE-13078-0.98-v1.patch
          19 kB
          Josh Elser
        4. HBASE-13078-v1.patch
          16 kB
          Josh Elser

        Issue Links

          is related to

          Test - A new unit, integration or system test. HBASE-13458 Create/expand unit test to exercise htrace instrumentation

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-12356 Rpc with region replica does not propagate tracing spans

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. HBASE-13077 BoundedCompletionService doesn't pass trace info to server

          • Major - Major loss of function.
          • Closed

          Activity

            People

              elserj Josh Elser
              ndimiduk Nick Dimiduk
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: