[HBASE-12608] region_mover.rb does not log moving region count correctly when loading regions

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.98.8
• Fix Version/s: 1.0.0, 0.98.10, 1.1.0
• Component/s: shell
• Hadoop Flags: Reviewed
• Assignee: Jianwei Cui
• Reporter: Jianwei Cui
• Created: 02/Dec/14 03:05
• Updated: 06/Apr/18 17:54
• Resolved: 27/Dec/14 18:40

Description

region_mover.rb does not seem to log moving region count correctly by the following code:

    ...
    if currentServer and currentServer == servername
      $LOG.info("Region " + r.getRegionNameAsString() + " (" + count.to_s +
        " of " + regions.length.to_s + ") already on target server=" + servername)
      counter = counter + 1
      next
    end
    pool.launch(r,currentServer,count) do |_r,_currentServer,_count|
      $LOG.info("Moving region " + _r.getRegionNameAsString() + " (" + (_count + 1).to_s +
        " of " + regions.length.to_s + ") from " + _currentServer.to_s + " to server=" +
        servername);
      move(admin, _r, servername, _currentServer)
    end
    counter = counter + 1

It seems we should use 'counter' when logging and remove the duplicated variable 'count'.