Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10755

MetricsRegionSourceImpl creates metrics that start with a lower case

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.96.0
    • 0.99.0
    • None
    • None
    • Incompatible change, Reviewed
    • There used to be a mix of metrics starting with "namespace_" "and Namespace_", now all the metrics will use the latter.

    Description

      Noticed something while looking at MBeans; some metric names are capitalized while others aren't. This has the unwanted property of changing the metric names sorting. For example:

      Namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_scanNext_num_ops
      namespace_default_table_t_region_0122d54a90c9dc191857daf11e8a047d_metric_appendCount

      The reason for this is that MutableHistogram uses StringUtils.capitalize() on the metrics name (as create by MetricsRegionSourceImpl with "namespace_").

      I'm not sure what the intent was with capitalization, but either way it's a simple fix. eclark?

      Attachments

        1. HBASE-10755.patch
          0.7 kB
          Jean-Daniel Cryans

        Activity

          People

            jdcryans Jean-Daniel Cryans
            jdcryans Jean-Daniel Cryans
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: