[HADOOP-8291] jenkins: include support for binary patches

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Colin McCabe
• Created: 18/Apr/12 23:01
• Updated: 09/Aug/12 15:36

Description

git, as well as the latest version of the GNU patch program, include support for generating binary diffs. These are diffs between binary files.

If we added support for binary diffs to Jenkins, it would be very useful for testing changes which involve altering a binary file. Currently these changes are untestable by Jenkins, because binary diffs show up in older patch files like this:

diff --git hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored
index 5099ce2..75fb82f 100644
Binary files hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored and hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored differ

As you can see, this has no actual information about what the change was.

However, when using binary diffs (git diff --binary) you get something like this:

diff --git hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored
index 5099ce21b3026331ccda23d2fe289b6d7b427f69..75fb82ff751954afd796641f467c09e13e3ce0a2 100644
GIT binary patch
delta 60
zcmZpYS}C>RD~|~W0|Zzz@aU&y=A_0a7o{eaqyhyw@>0v)i}Fhg-Us^0i9?myFdlcG
F2msT84>SM(

delta 21
YcmZ1})g-myD-W+Y0|Z#lUwp|306=R6wg3PC

We should add support for this to Jenkins. It might be as simple as upgrading the version of GNU patch on the server.

Issue Links

• relates to: HDFS-3731 2.0 release upgrade must handle blocks being written from 1.0