[#HADOOP-6150] Need to be able to instantiate a comparator instance from a comparator string without creating a TFile.Reader object

Hadoop Common

Need to be able to instantiate a comparator instance from a comparator string without creating a TFile.Reader object

Created: 15/Jul/09 12:32 AM Updated: 31/Jul/09 02:08 AM

Return to search

Component/s:

Affects Version/s:

0.20.0, 0.21.0

Fix Version/s:

0.20.0, 0.21.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
HADOOP-6150-0721.patch	2009-07-21 08:31 AM	Hong Tang	1 kB
HADOOP-6150-0723-for-20.patch	2009-07-23 09:32 PM	Hong Tang	1 kB

Resolution Date:

31/Jul/09 02:08 AM

Description

« Hide

Occasionally, we want have the same instance of comparator object represented by the TFile comparator string. We should be able to do that without requiring to first open up a tfile that was previously written use the same comparator.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Hong Tang added a comment - 21/Jul/09 08:32 AM

Trivial patch that exposes an internal API to public. No unit test needed.

[ Permlink | « Hide ]

Hong Tang added a comment - 23/Jul/09 09:32 PM

Same patch for hadoop 0.20.

[ Permlink | « Hide ]

Hong Tang added a comment - 24/Jul/09 12:05 AM

test-patch output for patch for hadoop trunk:

[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

[ Permlink | « Hide ]

Raghu Angadi added a comment - 24/Jul/09 12:08 AM

+1.

[ Permlink | « Hide ]

Hong Tang added a comment - 24/Jul/09 12:36 AM

test-patch output for patch for hadoop 20:

[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

[ Permlink | « Hide ]

Raghu Angadi added a comment - 24/Jul/09 01:15 AM

I just committed this. Thanks Hong.