FSDirectory should not have public methods.

• Key: HADOOP-5127
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Jakob Homan
• Reporter: Konstantin Shvachko
• Fix Version/s: 0.19.1

Description

FSDirectory class contains public constructors and methods. All of them except for one close() can be converted into package private.

Comments

[Jakob Homan]

Patch:

• Converts all public methods (except close) to package private.
• Converts public class field boolean ready to private

Passes all unit tests except the usual one.
Test-patch:

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

No new unit tests because is just a visibility refactoring and not easily testable.

[Jakob Homan]

Submitting patch

[Konstantin Shvachko]

+1 This looks good.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12399853/HADOOP-5127.patch
against trunk revision 742698.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3822/console

This message is automatically generated.

[Jakob Homan]

The failing unit test on Hudson is a known-bad Chukwa test. I don't understand why it says both core tests and contrib tests failed, the results don't show that. The unit tests all passed on my machine except known-bad HADOOP-4907.

[Jakob Homan]

The failing test is called out in HADOOP-5127 as failing regularly.

[Konstantin Shvachko]

I just committed this. Thank you Jacob.

[Konstantin Shvachko]

This is the patch I applied to 0.20 and 0.19 branches.

[Hudson]

Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/)