[#HADOOP-4961] ConcurrentModificationException in lease recovery of empty files.

Hadoop Common

ConcurrentModificationException in lease recovery of empty files.

Created: 31/Dec/08 03:00 AM Updated: 08/Jul/09 04:43 PM

Return to search

Component/s:

None

Affects Version/s:

0.18.0

Fix Version/s:

0.18.3

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
CMEinLeaseRecovery-0-18.patch	2008-12-31 06:33 AM	Konstantin Shvachko	4 kB
CMEinLeaseRecovery-0-19.patch	2008-12-31 07:34 PM	Konstantin Shvachko	5 kB
CMEinLeaseRecovery.patch	2008-12-31 06:33 AM	Konstantin Shvachko	4 kB
TestLeaseExpire.java	2008-12-31 03:02 AM	Tsz Wo (Nicholas), SZE	3 kB

Issue Links:

Reference

This issue is related to:

~~HADOOP-4951~~ Lease monitor does not own the LeaseManager lock in changing leases.

~~HADOOP-3113~~ DFSOututStream.flush() should flush data to real block file on DataNode.

Hadoop Flags:	Reviewed
Resolution Date:	31/Dec/08 07:35 PM

Description

« Hide

The problem is that internalReleaseLease() finalizes empty files, which removes these file path names from the lease. So this modifies the Collection of file names which LeaseManager.checkLeases() is iterating on.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#730439	Wed Dec 31 18:31:23 UTC 2008	shv	~~HADOOP-4961~~. Fix ConcurrentModificationException in lease recovery of empty files. Contributed by Konstantin Shvachko and Nicholas.
				Files Changed
				ADD /hadoop/core/trunk/src/test/org/apache/hadoop/hdfs/TestFileCreationEmpty.java MODIFY /hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java MODIFY /hadoop/core/trunk/CHANGES.txt

Repository	Revision	Date	User	Message
ASF	#730442	Wed Dec 31 18:41:51 UTC 2008	shv	~~HADOOP-4961~~. Merge -r 730438:730439 from trunk to branch 0.20.
				Files Changed
				ADD /hadoop/core/branches/branch-0.20/src/test/org/apache/hadoop/hdfs/TestFileCreationEmpty.java MODIFY /hadoop/core/branches/branch-0.20/CHANGES.txt MODIFY /hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java

Repository	Revision	Date	User	Message
ASF	#730449	Wed Dec 31 19:24:21 UTC 2008	shv	~~HADOOP-4961~~. Merge -r 730438:730439 from trunk to branch 0.19.
				Files Changed
				ADD /hadoop/core/branches/branch-0.19/src/test/org/apache/hadoop/hdfs/TestFileCreationEmpty.java MODIFY /hadoop/core/branches/branch-0.19/src/hdfs/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java MODIFY /hadoop/core/branches/branch-0.19/CHANGES.txt

Repository	Revision	Date	User	Message
ASF	#730451	Wed Dec 31 19:33:04 UTC 2008	shv	~~HADOOP-4961~~. Merge -r 730438:730439 from trunk to branch 0.18.
				Files Changed
				MODIFY /hadoop/core/branches/branch-0.18/src/hdfs/org/apache/hadoop/dfs/LeaseManager.java ADD /hadoop/core/branches/branch-0.18/src/test/org/apache/hadoop/dfs/TestFileCreationEmpty.java MODIFY /hadoop/core/branches/branch-0.18/CHANGES.txt