[#HADOOP-4737] Job end notification should give status as "KILLED" when job gets killed.

Hadoop Common

Job end notification should give status as "KILLED" when job gets killed.

Created: 27/Nov/08 08:07 AM Updated: 08/Jul/09 04:53 PM

Return to search

Component/s:

None

Affects Version/s:

0.15.2

Fix Version/s:

0.20.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
patch-4737-1.txt	2008-12-10 05:24 AM	Amareshwari Sriramadasu	9 kB
patch-4737.txt	2008-12-05 02:16 PM	Amareshwari Sriramadasu	7 kB

Hadoop Flags:	Reviewed
Resolution Date:	11/Dec/08 04:18 PM

Description

« Hide

Currently in Job End notification, there are only 2 statuses : SUCCEEDED or FAILED. But as we now have job end status as Killed also, job end notification should give status as "KILLED" when job gets killed.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 05/Dec/08 02:16 PM

Patch fixing JobEndNotifier. Updated NotificationTestcase to test FAILED and KILLED jobs.
Fixed LocalJobRunner to set state as KILLED when a job is KILLED.

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

All core and contrib tests passed on my machine

[ Permlink | « Hide ]

Alejandro Abdelnur added a comment - 08/Dec/08 10:36 AM

it looks good

[ Permlink | « Hide ]

Hadoop QA added a comment - 09/Dec/08 10:34 PM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395413/patch-4737.txt
against trunk revision 724578.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/console

This message is automatically generated.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 10/Dec/08 03:55 AM

TestLocalMRNotification passes on machine.
[junit] Running org.apache.hadoop.mapred.TestLocalMRNotification
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 10.097 sec
trying hudson again.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 10/Dec/08 05:24 AM

Fixed a bug in LocalJobRunner from the earlier patch to set the state KILLED.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 10/Dec/08 08:00 AM

test-patch result had no warnings. All core and contrib unit tests passed on my machine

[ Permlink | « Hide ]

Devaraj Das added a comment - 11/Dec/08 04:18 PM

I just committed this. Thanks, Amareshwari!