documentation typos: "the the"

• Key: HADOOP-4726
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Edward J. Yoon
• Reporter: Tsz Wo (Nicholas), SZE
• Component/s: documentation
• Affects Version/s: 0.18.2
• Fix Version/s: 0.18.3

Description

Try searching "the the" in the documentation files. See http://issues.apache.org/jira/browse/HADOOP-4704?focusedCommentId=12649589#action_12649589 for a list.

Comments

[Edward J. Yoon]

Here's another one typos: "intermedate" --> "intermediate"

throw (IOException)new IOException
("Intermedate merge failed").initCause(e);

[Edward J. Yoon]

I would like to work on this issue.

[Edward J. Yoon]

ugh, what is HADOOP-4704 different from this? bug report seems duplicated.

[Tsz Wo (Nicholas), SZE]

HADOOP-4704 is for javadoc. This one is for forrest doc and other documentation like hadoop-default.html.

[Tsz Wo (Nicholas), SZE]

Do you still want to work on this, Edward?

[Edward J. Yoon]

Oh, OK. Let me work on it.

[Tsz Wo (Nicholas), SZE]

Thanks, Edward.

[Edward J. Yoon]

Attach my patch.

[Edward J. Yoon]

Submitting.

[Tsz Wo (Nicholas), SZE]

+1 patch looks good. Could you also post corresponding patches for 0.18 and 0.19?

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394719/HADOOP-4726.patch
against trunk revision 721415.

+1 @author. The patch does not contain any @author tags.

+0 tests included. The patch appears to be a documentation patch that doesn't require tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3665/console

This message is automatically generated.

[Edward J. Yoon]

>> Could you also post corresponding patches for 0.18 and 0.19?

Oh, yes. Let's apply it to the 0.18.3

[Edward J. Yoon]

re-attach the patch for 0.18.3-dev

[Tsz Wo (Nicholas), SZE]

Hi Edward, HADOOP-4726_for_0.18.patch cannot be applied to 0.18. Could you check that?

[Edward J. Yoon]

Oh, sorry. the previous patch is clearly wrong.
please try this patch.

---

[root@udanax hadoop-0.18]# patch -p0 < HADOOP-4726_v02.patch
patching file conf/hadoop-default.xml
patching file docs/jdiff/hadoop_0.17.0.xml
patching file docs/jdiff/hadoop_0.18.1.xml
patching file docs/jdiff/hadoop_0.18.2.xml
patching file src/docs/src/documentation/content/xdocs/cluster_setup.xml
patching file src/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml
patching file src/docs/src/documentation/content/xdocs/mapred_tutorial.xml
patching file src/docs/src/documentation/content/xdocs/streaming.xml
[root@udanax hadoop-0.18]#

[Tsz Wo (Nicholas), SZE]

• ReduceTask.java is missing in HADOOP-4726_v02.patch.

• Seems there are some EOL changes in streaming.xml. It confuses svn. Tried to apply HADOOP-4726.patch (or HADOOP-4726_v02.patch) and than did "svn diff > a.patch". The resulted a.patch contained the entire streaming.xml file.

[Edward J. Yoon]

Thanks for your review. I fixed them.

---

[root@udanax hadoop-0.18]# patch -p0 < ~/Desktop/HADOOP-4726_v04.patch
...
+ patching file src/mapred/org/apache/hadoop/mapred/ReduceTask.java
...
[root@udanax hadoop-0.18]# svn diff > a.patch
[root@udanax hadoop-0.18]# cat a.patch

Index: src/docs/src/documentation/content/xdocs/streaming.xml
===================================================================
— src/docs/src/documentation/content/xdocs/streaming.xml (revision 722337)
+++ src/docs/src/documentation/content/xdocs/streaming.xml (working copy)
@@ -48,11 +48,11 @@
....

[Tsz Wo (Nicholas), SZE]

HADOOP-4726.patch also has a eol problem in streaming.xml. I fixed it. 4726_20081202.patch is the patch committed.

[Tsz Wo (Nicholas), SZE]

I just committed this. Thanks, Edward!

[Hudson]

Integrated in Hadoop-trunk #677 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/677/)
. Fix documentation typos "the the". (Edward J. Yoon via szetszwo)