Issue Details (XML | Word | Printable)

Key: HADOOP-4666
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Matei Zaharia
Reporter: Matei Zaharia
Votes: 0
Watchers: 6
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Launch reduces only after a few maps have run in the Fair Scheduler

Created: 15/Nov/08 11:54 PM   Updated: 08/Jul/09 04:41 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.20.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works fairscheduler-reduce-launch-condition.patch 2008-11-21 10:59 PM Matei Zaharia 5 kB

Hadoop Flags: Reviewed
Resolution Date: 24/Nov/08 11:30 AM


 Description  « Hide
It makes no sense to schedule reduces for a job before its maps have started running. As an initial fix, we will wait until a certain percent have run (likely 10%). In the future it would be good to choose the time to wait based on amount of map output data as well - launching reducers that will mostly be idle is not helpful. Average amount of map output bytes per mapper is easy to compute using counters in JobInProgress.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Matei Zaharia added a comment - 21/Nov/08 10:59 PM
Here is a patch for this issue that waits for at least 5% of maps to be launched, as will be happening in HADOOP-3136. (Patch also includes some minor formatting fixes.)

dhruba borthakur added a comment - 21/Nov/08 11:16 PM
+1. Code looks good.

Hadoop QA added a comment - 23/Nov/08 09:19 AM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394462/fairscheduler-reduce-launch-condition.patch
against trunk revision 719787.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 5 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3637/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3637/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3637/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3637/console

This message is automatically generated.


Johan Oskarsson added a comment - 24/Nov/08 11:30 AM
I just committed this. Thanks Matei!

Johan Oskarsson added a comment - 24/Nov/08 12:40 PM
The tests failures were not related to the patch. I've created this issue for one of them that I've seen time out in a few other patch runs. HADOOP-4716

Matei Zaharia added a comment - 24/Nov/08 05:25 PM
Thanks Johan for the quick commit.

Hudson added a comment - 25/Nov/08 06:39 PM
Integrated in Hadoop-trunk #670 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/670/)
. Launch reduces only after a few maps have run in the Fair Scheduler. (Matei Zaharia via johan)