browseBlock.jsp does not generate "genstamp" property.

• Key: HADOOP-4613
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Johan Oskarsson
• Reporter: Konstantin Shvachko
• Affects Version/s: 0.18.0
• Fix Version/s: 0.18.3

Description

A link to a block replica display page on the web UI breaks with the following message: "Invalid input (genstamp absent)".
The reason is that browsBlock.jsp sets "genstamp=" in the code two times out of three.
One spot in line #148 was missed by HADOOP-2656.

Comments

[Johan Oskarsson]

Is this what you had in mind Konstantin? One line, adds:
"&genstamp=" + cur.getBlock().getGenerationStamp() +

[Tsz Wo (Nicholas), SZE]

Konstantin, could you take a look at the patch?

[Konstantin Shvachko]

+1 this would work.
Making it patch available.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394658/HADOOP-4613.patch
against trunk revision 724931.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3698/console

This message is automatically generated.

[Konstantin Shvachko]

I just committed this. Thank you Johan.

[Hudson]

Integrated in Hadoop-trunk #685 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/685/)
. Fix block browsing on Web UI. Contributed by Johan Oskarsson.