[#HADOOP-4505] Add a unit test to test faulty setup task and cleanup task killing the job

Hadoop Common

Add a unit test to test faulty setup task and cleanup task killing the job

Created: 23/Oct/08 11:41 AM Updated: 08/Jul/09 04:53 PM

Return to search

Component/s:

None

Affects Version/s:

0.19.0

Fix Version/s:

0.20.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	patch-4505.txt	2008-10-24 06:36 AM	Amareshwari Sriramadasu	5 kB

Hadoop Flags:	Reviewed
Resolution Date:	12/Nov/08 04:48 PM

Description

« Hide

We should have a unit test which tests faulty setup task or cleanup task of the job eventually kills the job.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 24/Oct/08 06:36 AM

Patch adding the unit test

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 24/Oct/08 08:52 AM

test-patch result:

     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]

All core and contrib tests passed on machine.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 30/Oct/08 10:25 AM

submitting to hudson again

[ Permlink | « Hide ]

Hadoop QA added a comment - 30/Oct/08 07:16 PM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392768/patch-4505.txt
against trunk revision 709040.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3512/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3512/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3512/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3512/console

This message is automatically generated.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 31/Oct/08 04:08 AM

Test failure is not related to the patch. The patch just adds a unit test. it doesn't touch the core code.
All the core and contrib tests pass on my machine.

[ Permlink | « Hide ]

Johan Oskarsson added a comment - 12/Nov/08 04:48 PM

I just committed this. Thanks Amareshwari!

[ Permlink | « Hide ]

Hudson added a comment - 13/Nov/08 02:11 AM

Integrated in Hadoop-trunk #659 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/659/)
. Add a unit test to test faulty setup task and cleanup task killing the job. (Amareshwari Sriramadasu via johan)