Issue Details (XML | Word | Printable)

Key: HADOOP-4257
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Tsz Wo (Nicholas), SZE
Reporter: Vinod K V
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

TestLeaseRecovery2.testBlockSynchronization failing.

Created: 24/Sep/08 04:27 AM   Updated: 08/Jul/09 04:43 PM
Return to search
Component/s: test
Affects Version/s: None
Fix Version/s: 0.18.3

Time Tracking:
Not Specified

File Attachments:
  File Name Date Attached Attached By Size
Text File Licensed for inclusion in ASF works 4257_20080929.patch 2008-09-29 11:39 PM Tsz Wo (Nicholas), SZE 4 kB
Text File Licensed for inclusion in ASF works 4257_20080929b.patch 2008-09-29 11:40 PM Tsz Wo (Nicholas), SZE 4 kB
Text File Licensed for inclusion in ASF works 4257_20080930.patch 2008-09-30 11:41 PM Tsz Wo (Nicholas), SZE 8 kB
Text File Licensed for inclusion in ASF works 4257_20080930b.patch 2008-10-01 01:15 AM Tsz Wo (Nicholas), SZE 9 kB
Text File Licensed for inclusion in ASF works 4257_20081001.patch 2008-10-02 01:00 AM Tsz Wo (Nicholas), SZE 11 kB
Text File Licensed for inclusion in ASF works 4257_20081001b.patch 2008-10-02 01:40 AM Tsz Wo (Nicholas), SZE 11 kB
Text File Licensed for inclusion in ASF works 4257_20081002.patch 2008-10-02 12:44 PM Tsz Wo (Nicholas), SZE 11 kB
Text File Licensed for inclusion in ASF works 4257_20081002_0.18.patch 2008-12-01 07:29 PM Tsz Wo (Nicholas), SZE 14 kB
File Licensed for inclusion in ASF works runtest 2008-10-08 05:33 PM Tsz Wo (Nicholas), SZE 0.4 kB
HTML File testClientTriggeredLeaseRecovery.htm 2008-09-24 10:52 PM Raghu Angadi 490 kB
Text File TestLeaseRecovery2-1.txt 2008-09-24 10:42 PM Raghu Angadi 391 kB
Issue Links:
Reference
 

Hadoop Flags: Reviewed
Resolution Date: 03/Oct/08 04:59 AM


 Description  « Hide
Found this while running HADOOP-4173 through Hudson.

HadoopQA output:

org.apache.hadoop.hdfs.TestLeaseRecovery2.testBlockSynchronization
Failing for the past 2 builds (Since Failed#3352 )
Took 0 seconds.
Error Message

Timeout occurred. Please note the time in the report does not reflect the time until the timeout.

Stacktrace

junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.

See http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3353/testReport/org.apache.hadoop.hdfs/TestLeaseRecovery2/testBlockSynchronization/ and http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3352/testReport/org.apache.hadoop.hdfs/TestLeaseRecovery2/testBlockSynchronization/

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
Raghu Angadi added a comment - 24/Sep/08 10:33 PM
There are quite a few failures for TestLeaseRecovery2. I will attach couple of examples.

[ Permlink | « Hide ]
Raghu Angadi added a comment - 24/Sep/08 10:52 PM
Couple of lease recovery related failures :
  • TestLeaseRecovery2-1.txt : from nightly failure.
  • testClientTriggeredLeaseRecovery.htm : core-test failure from HADOOP-4173.

[ Permlink | « Hide ]
Raghu Angadi added a comment - 24/Sep/08 10:55 PM
Edited comment for clarity.. not hijacked.

[ Permlink | « Hide ]
Raghu Angadi added a comment - 24/Sep/08 10:58 PM
> Edited comment for clarity.. not hijacked.
I wanted to say "Edited title ..."

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 25/Sep/08 08:12 PM
This seems related to HADOOP-3614.

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 29/Sep/08 11:39 PM
4257_20080929.patch: fixed 2 bugs
  • Namenode should assign only one datanode as primary but not multiple datanodes
  • In FSDataset.updateBlock(...), renaming block meta file may fail because there may be multiple updateBlock(...) calls.

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 29/Sep/08 11:40 PM
4257_20080929b.patch: forgot to reset the RANDOM_NUMBER_GENERATOR_SEED in my last patch.

[ Permlink | « Hide ]
dhruba borthakur added a comment - 30/Sep/08 12:05 AM
Great catch(es).

+1. Code looks good.


[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 30/Sep/08 01:26 AM 
     [exec] +1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

Tested locally: only TestReduceFetch failed but it is not related to this issue. See HADOOP-4302. Submitting ...


[ Permlink | « Hide ]
Hadoop QA added a comment - 30/Sep/08 06:13 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391175/4257_20080929b.patch
against trunk revision 700322.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3403/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3403/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3403/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3403/console

This message is automatically generated.


[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 30/Sep/08 11:41 PM
4257_20080930.patch: cleaned up TestLeaseRecovery2

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 01/Oct/08 01:15 AM
4257_20080930b.patch: it passed TestLeaseRecovery2 around 20 times in my machine.

[ Permlink | « Hide ]
Hadoop QA added a comment - 01/Oct/08 11:00 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391253/4257_20080930b.patch
against trunk revision 700887.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3416/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3416/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3416/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3416/console

This message is automatically generated.


[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 02/Oct/08 01:00 AM
4257_20081001.patch: fixed another bug in BlockSender.sendChunks(...).

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 02/Oct/08 01:40 AM
4257_20081001b.patch: changed some test log messages

[ Permlink | « Hide ]
Hadoop QA added a comment - 02/Oct/08 08:29 AM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391340/4257_20081001b.patch
against trunk revision 700997.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3421/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3421/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3421/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3421/console

This message is automatically generated.


[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 02/Oct/08 12:44 PM
4257_20081002.patch: fixed a bug in TestLeaseRecovery2: sleep too short + heartbeat too long => time out

Passed the tests locally with same random number generator seed used in build #3421.


[ Permlink | « Hide ]
Hadoop QA added a comment - 02/Oct/08 06:39 PM
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391355/4257_20081002.patch
against trunk revision 700997.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3424/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3424/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3424/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3424/console

This message is automatically generated.


[ Permlink | « Hide ]
dhruba borthakur added a comment - 02/Oct/08 08:46 PM
Code looks good. +1.

[ Permlink | « Hide ]
dhruba borthakur added a comment - 03/Oct/08 04:59 AM
I just committed this. Thanks Nicholas!

[ Permlink | « Hide ]
Hudson added a comment - 03/Oct/08 02:31 PM
Integrated in Hadoop-trunk #622 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/622/)
. The DFS client should pick only one datanode as the candidate
to initiate lease recovery. (Tsz Wo (Nicholas), SZE via cdouglas)

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 08/Oct/08 05:33 PM
runtest: this is a simple script I used to run a single test repeatedly. I think someone else may find it useful.

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 01/Dec/08 07:29 PM
4257_20081002_0.18.patch: the issue should also be committed to 0.18.

[ Permlink | « Hide ]
Tsz Wo (Nicholas), SZE added a comment - 01/Dec/08 10:06 PM
Tested the patch locally. Everything works fine. I have committed this to 0.18.

[ Permlink | « Hide ]
Hudson added a comment - 03/Dec/08 02:32 PM
Integrated in Hadoop-trunk #677 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/677/)


Powered by a free Atlassian JIRA open source license for Apache Software Foundation. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators