Issue Details (XML | Word | Printable)

Key: HADOOP-3730
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Alejandro Abdelnur
Reporter: Alejandro Abdelnur
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

add new JobConf constructor that disables loading default configurations

Created: 09/Jul/08 05:32 PM   Updated: 08/Jul/09 04:53 PM
Return to search
Component/s: conf
Affects Version/s: None
Fix Version/s: 0.19.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works patch3730.txt 2008-07-15 07:47 AM Alejandro Abdelnur 5 kB
Text File Licensed for inclusion in ASF works patch3730.txt 2008-07-14 09:29 AM Alejandro Abdelnur 1 kB
Text File Licensed for inclusion in ASF works patch3730.txt 2008-07-10 11:10 AM Alejandro Abdelnur 0.8 kB
Environment: all
Issue Links:
Reference
 

Hadoop Flags: Reviewed
Release Note:  Added a JobConf constructor that disables loading default configurations so as to take all default values from the JobTracker's configuration.
Resolution Date: 16/Jul/08 06:00 PM


 Description  « Hide
Similar to the Configuration(boolean loadDefauls) , JobConf should have such constructor.

This would allow supporting default values on the JT side as the client would not submit its default values in the job.xml.

It would address Hadoop-3287



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Hadoop QA added a comment - 12/Jul/08 04:16 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385734/patch3730.txt
against trunk revision 676069.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2843/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2843/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2843/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2843/console

This message is automatically generated.


Alejandro Abdelnur added a comment - 14/Jul/08 09:29 AM
adding testcase

Hadoop QA added a comment - 14/Jul/08 11:18 AM
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385964/patch3730.txt
against trunk revision 676069.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2855/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2855/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2855/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2855/console

This message is automatically generated.


Alejandro Abdelnur added a comment - 15/Jul/08 07:47 AM
adding a separate testcase to test for JobConf with no defaults.

testcase tests that a job submitted with a JobConf with no defaults is submitted and executed properly by Hadoop as the JT injects its own defaults.


Hadoop QA added a comment - 16/Jul/08 09:41 AM
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12386037/patch3730.txt
against trunk revision 677127.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2870/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2870/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2870/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2870/console

This message is automatically generated.


Devaraj Das added a comment - 16/Jul/08 06:00 PM
I just committed this. Thanks, Alejandro!

Hudson added a comment - 22/Aug/08 12:34 PM