|
[
Permlink
| « Hide
]
Konstantin Shvachko added a comment - 24/Jun/08 03:17 AM
Here is the documentation.
+1 Looks good
PS: Shouldnt the patch contain only .xml file changes? It is a good idea to document fs.checkpoint.period and .size properties. I did that.
By saying "create empty directory" I actually mean creating an empty directory that is the one that does not contain anything inside. Don' know how to clarify it better. Yes you are right that the implementation checks only that the directory does not contain a legal image, but I think the documentation should say empty directory, that way there will be no confusion if we ever change any thing in the internal directory structure. I thought we commit xml files as well as the generated by forrest html and pdf files. So my patch contains all three. Please let me know if this is wrong. I just committed this.
Integrated in Hadoop-trunk #529 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/529/
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||