Issue Details (XML | Word | Printable)

Key: HADOOP-3501
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Doug Cutting
Reporter: Doug Cutting
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

deprecate InMemoryFileSystem

Created: 05/Jun/08 04:47 PM   Updated: 22/Aug/08 07:50 PM
Return to search
Component/s: fs
Affects Version/s: 0.17.0
Fix Version/s: 0.18.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works 3051.patch 2008-06-06 07:47 PM Devaraj Das 1 kB
Text File Licensed for inclusion in ASF works HADOOP-3051.patch 2008-06-05 04:53 PM Doug Cutting 2 kB

Hadoop Flags: Reviewed
Resolution Date: 06/Jun/08 08:14 PM


 Description  « Hide
As of HADOOP-2095, InMemoryFileSystem is no longer used. Its design was optimized for a particular application and it is thus not a good general-purpose RAM-based FileSystem implementation, so it ought to be removed.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Doug Cutting added a comment - 05/Jun/08 04:53 PM
Patch to deprecate InMemoryFileSystem.

Arun C Murthy added a comment - 05/Jun/08 06:58 PM
+1

We can fix the test-case which uses the InMemoryFileSystem at a latter point.


Hadoop QA added a comment - 05/Jun/08 08:12 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383471/HADOOP-3051.patch
against trunk revision 663487.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The applied patch generated 455 javac compiler warnings (more than the trunk's current 452 warnings).

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2593/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2593/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2593/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2593/console

This message is automatically generated.


Doug Cutting added a comment - 05/Jun/08 09:52 PM
> -1 javac. The applied patch generated 455 javac compiler warnings (more than the trunk's current 452 warnings).

This is expected, since this patch adds a deprecation.

> -1 core tests. The patch failed core unit tests.
> -1 contrib tests. The patch failed contrib unit tests.

These same tests are failing for other patches and are unrelated to this patch.


Devaraj Das added a comment - 06/Jun/08 07:47 PM
This patch is w.r.t the trunk.

Devaraj Das added a comment - 06/Jun/08 07:49 PM
Pushing through hudson

Owen O'Malley added a comment - 06/Jun/08 08:14 PM
I just committed this. Thanks, Doug!