Name-node shutdown causes InterruptedException in ResolutionMonitor

• Key: HADOOP-3491
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Lohit Vijayarenu
• Reporter: Konstantin Shvachko
• Affects Version/s: 0.16.0
• Fix Version/s: 0.18.0

Description

ResolutionMonitor.run() catches a general Exception and logs them no matter what.
It should explicitly catch the InterruptedException and exit gracefully.

Comments

[Lohit Vijayarenu]

Attached patch, catches the exception and logs a one line warning instead of whole stack trace.

[Lohit Vijayarenu]

[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.

No tests, I manually checked logs and dont see strack dump as earlier.

[Konstantin Shvachko]

I think InterruptedException should be caught inside the loop so that the ResolutionMonitor could check fsRunning and decide what to do based on its value.
And there should be no messages higher than debug level, imo.

[Lohit Vijayarenu]

Thanks Konstantin, Second try with your comments.

[Lohit Vijayarenu]

[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]

[Konstantin Shvachko]

+1

[Konstantin Shvachko]

I just committed this. Thank you Lohit.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12383602/HADOOP-3491-3.patch
against trunk revision 664159.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2612/console

This message is automatically generated.