[#HADOOP-3334] Move lease handling codes out from FSNamesystem

Hadoop Common

Move lease handling codes out from FSNamesystem

Created: 01/May/08 06:52 PM Updated: 08/Jul/09 04:43 PM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

0.18.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
3334_20080501.patch	2008-05-01 09:45 PM	Tsz Wo (Nicholas), SZE	35 kB
3334_20080501b.patch	2008-05-02 03:01 AM	Tsz Wo (Nicholas), SZE	35 kB
3334_20080502.patch	2008-05-02 11:52 PM	Tsz Wo (Nicholas), SZE	35 kB
3334_20080506.patch	2008-05-06 06:51 PM	Tsz Wo (Nicholas), SZE	35 kB

Hadoop Flags:	Reviewed
Resolution Date:	07/May/08 12:40 AM

Description

« Hide

Lease handling is a big component of FSNamesystem. It is better to put this component in its own class.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 01/May/08 09:45 PM

3334_20080501.patch:

created a new class LeaseManager
synchronized LeaseManager object instead of sortedLease

[ Permlink | « Hide ]

Hadoop QA added a comment - 02/May/08 02:46 AM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381277/3334_20080501.patch
against trunk revision 645773.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 6 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs -1. The patch appears to introduce 1 new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2363/console

This message is automatically generated.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 02/May/08 03:01 AM

3334_20080501b.patch: fixed the findbugs warning.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 02/May/08 11:52 PM

3334_20080502.patch: fixed a bug

[ Permlink | « Hide ]

Hadoop QA added a comment - 03/May/08 08:00 PM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381356/3334_20080502.patch
against trunk revision 645773.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 6 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2376/console

This message is automatically generated.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 05/May/08 06:12 PM

According the test report, the only tested failed is TEST-org.apache.hadoop.fs.TestCopyFiles.xml.<init>. Is TestCopyFiles.xml a valid test? I cannot find a file named "TestCopyFiles.xml". Does anyone know why it failed?