TestFileAppend fails on Mac since HADOOP-2655 was committed

• Key: HADOOP-3161
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Nigel Daley
• Reporter: Nigel Daley
• Component/s: test
• Affects Version/s: 0.17.0
• Fix Version/s: 0.17.0

Description

org.apache.hadoop.dfs.TestFileAppend.testCopyOnWrite fails with this exception:

java.io.IOException: stat: illegal option – c
at org.apache.hadoop.fs.FileUtil$HardLink.getLinkCount(FileUtil.java:557)
at org.apache.hadoop.dfs.DatanodeBlockInfo.detachBlock(DatanodeBlockInfo.java:117)
at org.apache.hadoop.dfs.FSDataset.detachBlock(FSDataset.java:652)
at org.apache.hadoop.dfs.TestFileAppend.testCopyOnWrite(TestFileAppend.java:188)

Mac command should be
stat -f$l

Comments

[Nigel Daley]

Adds OS_TYPE_MAC to FileUtil so file system commands can be properly specified for the Mac.

Without this patch, TestFileAppend fails (since Feb 26). With this patch that test passes.

[Nigel Daley]

Dhruba, can you review this?

[dhruba borthakur]

CopyOnWrite is needed for appends.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379228/HADOOP-3161.patch
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2140/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2140/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2140/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2140/console

This message is automatically generated.

[dhruba borthakur]

+1. Code looks good.

[Owen O'Malley]

I just committed this. Thanks, Nigel!

[Hudson]

Integrated in Hadoop-trunk #451 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/451/)