|
[
Permlink
| « Hide
]
Mahadev konar added a comment - 27/Mar/08 12:43 AM
most of these are tested in TestDFSShell .... testErrOut() method.
Initial patch with the test driver code and test cases for:
ls lsr du dus mv There are 31 test cases which perform 100 validations The test cases (input commands and expected output) are defined in the testConf.xml file. This is the file that will be updated with other test cases. Here is an updated patch. It includes changes to the test driver and additional tests. Thanks to Karam and Ramya for the additional tests. There are 139 tests with 283 validations being done.
The tests have been run on Windows, Mac and Linux. It adds < 30 seconds on linux/mac and 3 mins to the unit tests runtime on windows. I have run the ant test-patch target and there were no errors reported. [exec] @author +1. The patch does not contain any @author tags. [exec] tests included +1. The patch appears to include 323 new or modified tests. [exec] javadoc +1. The javadoc tool did not generate any warning messages. [exec] javac +1. The applied patch does not generate any new javac compiler warnings. [exec] findbugs +1. The patch does not introduce any new Findbugs warnings. Here are test cases being covered and the output from the test: 2008-04-30 09:45:55,298 INFO cli.TestCLI (TestCLI.java:displayResults(170)) - Detailed results: 2008-04-30 09:45:55,299 INFO cli.TestCLI (TestCLI.java:displayResults(215)) - Summary results: 2008-04-30 09:45:55,300 INFO cli.TestCLI (TestCLI.java:displayResults(236)) - Testing mode: test -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381203/H3100.patch against trunk revision 645773. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 327 new or modified tests. patch -1. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2353/console This message is automatically generated. -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381373/H3100.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 327 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 213 release audit warnings (more than the trunk's current 207 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2389/testReport/ This message is automatically generated. Canceling patch as it needs an update for trunk due to command like output changes in trunk
Updated patch to work with changes in 0.18.0
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12384159/H3100.patch against trunk revision 668832. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 327 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 209 release audit warnings (more than the trunk's current 203 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2674/testReport/ This message is automatically generated. Release audit warning are ok. The new files don't need Apache headers.
Test failure is due to org.apache.hadoop.cli.util.TestData not having any test methods. This class should be renamed so that it doesn't start with the work "Test". canceling patch until Nigel's suggestion of changing the class name is done.
Updated patch: renamed TestData to CLITestData
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12384623/H3100.patch against trunk revision 671277. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 327 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 213 release audit warnings (more than the trunk's current 207 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2727/testReport/ This message is automatically generated. Release audit warning are ok. The new files don't need Apache headers.
The patch is good to go Integrated in Hadoop-trunk #536 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/536/
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||