Issue Details (XML | Word | Printable)

Key: HADOOP-2854
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Lohit Vijayarenu
Reporter: Tsz Wo (Nicholas), SZE
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Remove the deprecated ipc.Server.getUserInfo()

Created: 19/Feb/08 11:34 PM   Updated: 08/Jul/09 04:42 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.17.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works HADOOP-2854-1.patch 2008-03-28 09:57 PM Lohit Vijayarenu 0.8 kB

Hadoop Flags: Incompatible change
Release Note: Removes deprecated method Server.getUserInfo()
Resolution Date: 29/Mar/08 01:36 AM


 Description  « Hide
The method org.apache.hadoop.ipc.Server.getUserInfo() is deprecated and is no longer used by other codes.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Robert Chansler made changes - 20/Feb/08 01:24 AM
Field Original Value New Value
Component/s dfs [ 12310710 ]
Nigel Daley made changes - 24/Mar/08 11:04 PM
Priority Major [ 3 ] Blocker [ 1 ]
Robert Chansler added a comment - 28/Mar/08 12:06 AM
If deprecated in 0.15, then remove for 0.17.
Otherwise set the fix version for this issue to 0.18.

Robert Chansler made changes - 28/Mar/08 12:06 AM
Assignee lohit vijayarenu [ lohit ]
Lohit Vijayarenu added a comment - 28/Mar/08 09:57 PM
This function was deprecated in 0.16 and is not being used anywhere else. Removing it in 0.17.

Lohit Vijayarenu made changes - 28/Mar/08 09:57 PM
Attachment HADOOP-2854-1.patch [ 12378821 ]
Lohit Vijayarenu made changes - 28/Mar/08 09:57 PM
Status Open [ 1 ] Patch Available [ 10002 ]
Tsz Wo (Nicholas), SZE added a comment - 28/Mar/08 09:59 PM
+1 patch looks good

Hadoop QA added a comment - 28/Mar/08 11:33 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378821/HADOOP-2854-1.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2092/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2092/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2092/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2092/console

This message is automatically generated.


Lohit Vijayarenu added a comment - 29/Mar/08 12:31 AM - edited
This removes a deprecated API and does not required a testcase. The core test failure is being fixed by HADOOP-3128. I pulled in patch from HADOOP-3128 and test passes.

Chris Douglas added a comment - 29/Mar/08 01:36 AM
I just committed this. Thanks, Lohit!

Chris Douglas made changes - 29/Mar/08 01:36 AM
Resolution Fixed [ 1 ]
Status Patch Available [ 10002 ] Resolved [ 5 ]
Repository Revision Date User Message
ASF #642476 Sat Mar 29 01:37:47 UTC 2008 cdouglas HADOOP-2854. Remove deprecated o.a.h.ipc.Server::getUserInfo().
(lohit vijayarenu via cdouglas)
Files Changed
MODIFY /hadoop/core/trunk/src/java/org/apache/hadoop/ipc/Server.java
MODIFY /hadoop/core/trunk/CHANGES.txt

Hudson added a comment - 29/Mar/08 12:07 PM

Robert Chansler added a comment - 14/Apr/08 04:30 PM
Noted as incompatible in changes.txt

Robert Chansler made changes - 14/Apr/08 04:30 PM
Hadoop Flags [Incompatible change]
Lohit Vijayarenu made changes - 18/Apr/08 12:12 AM
Release Note Removes deprecated method Server.getUserInfo()
Nigel Daley made changes - 21/May/08 08:05 PM
Status Resolved [ 5 ] Closed [ 6 ]
Owen O'Malley made changes - 08/Jul/09 04:42 PM
Component/s dfs [ 12310710 ]