Remove the deprecated INode.getAbsoluteName()

• Key: HADOOP-2831
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Lohit Vijayarenu
• Reporter: Tsz Wo (Nicholas), SZE
• Fix Version/s: 0.17.0

Description

The deprecated INode.getAbsoluteName() should be removed so that INode.parent could be eliminated later on.

INode.getAbsoluteName() currently is only used in FSImage.writeINodeUnderConstruction(...) . It also introduces unnecessary recursion.

Comments

[Robert Chansler]

If deprecated in 0.15, then remove for 0.17.
Otherwise set the fix version for this issue to 0.18.

[Lohit Vijayarenu]

Attaching patch which deprecates the API. There is one another place where this is use in log message. I changed it to use fileName already present instead of absolutePath()

[Lohit Vijayarenu]

was getting rid of wrong getAbsoluteName(). Reverting that. Thanks Nicolas.

[Tsz Wo (Nicholas), SZE]

+1 codes look good.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

patch -1. The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2105/console

This message is automatically generated.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378977/HADOOP-2831-2.patch
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2107/console

This message is automatically generated.

[Lohit Vijayarenu]

This patch removes deprecated API does so testcases were not included.

[Chris Douglas]

Would it make sense to remove o.a.h.dfs.BlockCrcUpgrade.INodeMapEntry::getAbsoluteName() as well?

[Chris Douglas]

Spoke with Lohit offline, cleared up my confusion.

I just committed this. Thanks, Lohit!

[Robert Chansler]

Noted as incompatible in changes.txt