[#HADOOP-2738] Text is not subclassable because set(Text) and compareTo(Object) access the other instance's private members directly

Hadoop Common

Text is not subclassable because set(Text) and compareTo(Object) access the other instance's private members directly

Created: 30/Jan/08 03:46 AM Updated: 21/May/08 08:05 PM

Return to search

Component/s:

Affects Version/s:

0.16.0

Fix Version/s:

0.17.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	patch.txt	2008-01-30 08:00 PM	Jim Kellerman	1 kB

Resolution Date:

30/Jan/08 09:52 PM

Description

« Hide

Text objects should not access other Text objects private members directly. Both set(Text) and compareTo(Object) do.
Because these two methods access private members of the other object, Text is not subclassable. Either these two methods should be modified to use the accessors that are already available, or Text should be declared as a final class, because as it exists today it is not subclassable.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Jim Kellerman made changes - 30/Jan/08 04:42 AM

Field	Original Value	New Value
Priority	Major [ 3 ]	Minor [ 4 ]

Jim Kellerman made changes - 30/Jan/08 08:00 PM

Attachment

patch.txt [ 12374406 ]

Jim Kellerman made changes - 30/Jan/08 08:01 PM

Status	Open [ 1 ]	Patch Available [ 10002 ]
Fix Version/s		0.17.0 [ 12312913 ]

Jim Kellerman made changes - 30/Jan/08 09:52 PM

Status	Patch Available [ 10002 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Nigel Daley made changes - 21/May/08 08:05 PM

Status

Resolved [ 5 ]

Closed [ 6 ]