dfs mv command differs from POSIX standards

• Key: HADOOP-2192
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Mahadev konar
• Reporter: Mukund Madhugiri
• Affects Version/s: 0.15.1, 0.16.0
• Fix Version/s: 0.17.0

Description

Assuming the dfs commands follow POSIX standards, there are some problems with the DFS mv command. I compared the DFS output with that of RHEL 4u5

1. mv a file:
Linux: No output
DFS: Renamed /testarea/hadoop-site.xml to test

2. mv a file/directory that does not exist. The DFS file does not exist, but the output says it renamed the file:
Linux: mv: cannot stat `testarea/one': No such file or directory
DFS: mv: Rename failed /testarea/one

3. mv a directory to another directory:
Linux: No output
DFS: Renamed /testarea to testarea2

Comments

[Mahadev konar]

this patch fixes the issues stated in the bug.

[Lohit Vijayarenu]

Looks good. Could we also get this fixed

Here build is dir and build.xml is file
DFS Output
[lohit@ hadoop-core-trunk]$ hadoop dfs -mv build build.xml
mv: Rename failed /user/lohit/build

LINUX output
[lohit@ hadoop-core-trunk]$ mv build build.xml
mv: cannot overwrite non-directory `build.xml' with directory `build'

[Mahadev konar]

this patch addresses the issue pointed out by lohit...

[Mahadev konar]

changed catchign IOException to FileNotfoundexception in call to getfilestatus. thanks lohit.

[Lohit Vijayarenu]

+1 looks good

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12375737/Hadoop-2192_3.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 7 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1811/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1811/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1811/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1811/console

This message is automatically generated.

[dhruba borthakur]

I just committed this. Thanks Mahadev!

[Hudson]

Integrated in Hadoop-trunk #407 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/407/)

[Robert Chansler]

Noted as incompatible in changes.txt