[GROOVY-6571] groovy.sql.Sql.eachRow should set maxRows on the JDBC Statement

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.1
• Fix Version/s: 2.3.1
• Component/s: SQL processing
• Assignee: Paul King
• Reporter: Jason Stell
• Created: 13/Feb/14 10:08
• Updated: 20/May/14 05:31
• Resolved: 05/May/14 16:00

Description

I noticed that executing groovy.sql.Sql.firstRow passes a maxRows parameter with value 1 to groovy.sql.Sql.eachRow. The maxRows value, however, is only used to limit ResultSet iteration.

I believe JDBC drivers can optimize the data that is actually retrieved if the maxRows is set on the Statement prior to executing the SQL. If maxRows is not set, the driver may prefetch more results than is necessary and the database may end up doing more work.

See http://docs.oracle.com/javase/7/docs/api/java/sql/Statement.html#setMaxRows(int)