[GEODE-6023] synchronization on non-final variable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: membership
• Assignee: Bruce J Schuchardt
• Reporter: Bruce J Schuchardt
• Created: 09/Nov/18 16:49
• Updated: 12/Nov/18 19:35
• Resolved: 12/Nov/18 19:35

Description

The class SocketCloser synchronizes on a non-final boxed instance variable, "closed".

    synchronized (closed) {
      if (!this.closed) {
        this.closed = true;
      } else {
        return;
      }
    }

This is probably okay but it's flagged as an ERROR by LGTM scans and we shouldn't be using auto-boxed variables in non-test code.