[GEODE-5732] TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: transactions
• Labels: pull-request-available swat
• Assignee: Bill Burcham
• Reporter: Bill Burcham
• Created: 12/Sep/18 16:56
• Updated: 17/Sep/18 18:41
• Resolved: 17/Sep/18 18:41

Description

The various toDataXX and fromDataXX methods purport to test serialization/deserialization of TXCommitMessage between different product versions. Primarily, this entails looking for presence/absence of the shadow key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests actually fail when we break the product.

The fix is to not use mocking for these tests, and to instead serialize/deserialize to/from buffers.

Issue Links

• links to: GitHub Pull Request #2462