[FLINK-8165] ParameterTools not serializable properly

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.4.0, 1.5.0
• Fix Version/s: 1.4.0
• Component/s: Runtime / Configuration
• Assignee: Gyula Fora
• Reporter: Gyula Fora
• Created: 29/Nov/17 08:57
• Updated: 28/Feb/19 14:29
• Resolved: 29/Nov/17 14:48

Description

Trying to get with default value after deserialization fails as the EmptyMap doesn't support put operations for new default values.

The problem is here:

https://github.com/apache/flink/blob/release-1.4.0-rc2/flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java#L621

Reproduce:

	@Test
	public void tes() throws IOException, ClassNotFoundException {
		ParameterTool params = ParameterTool.fromMap(new HashMap<>());
                // works
		params.get("asd", "default");
		byte[] b = InstantiationUtil.serializeObject(params);
		ParameterTool dparams = InstantiationUtil.deserializeObject(b, getClass().getClassLoader());
                 // fails
		dparams.get("asd", "default");
	}

Issue Links

• links to: GitHub Pull Request #5096