[FLINK-8139] Check for proper equals() and hashCode() when registering a table

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: Table SQL / API
• Assignee: Aegeaner
• Reporter: Timo Walther
• Created: 23/Nov/17 11:07
• Updated: 05/Jan/18 16:17
• Resolved: 05/Jan/18 16:17

Description

In the current Table API & SQL implementation we compare {{Row}}s at different positions. E.g., for joining we test rows for equality or put them into state. A heap state backend requires proper hashCode() and equals() in order to work correct. Thus, every type in the Table API needs to have these methods implemented.

We need to check if all fields of a row have implement methods that differ from Object.equals() and Object.hashCode() via reflections. Both coming from TableSource and DataStream/DataSet.

Additionally, for array types, the Row class should use Arrays.deepEquals() and Arrays.deepHashCode() instead of the non-deep variants.

Issue Links

• links to: GitHub Pull Request #5065