[FLINK-33817] Allow ReadDefaultValues = False for non primitive types on Proto3

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.18.0
• Fix Version/s: 1.20.0
• Component/s: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
• Labels: pull-request-available

Release Note

Protobuf format now supports set 'protobuf.read-default-values' = 'false' for non-primitive types on pb3. Since the default value for 'protobuf.read-default-values' is 'false', this is a breaking change, if you are using pb3, you can set 'protobuf.read-default-values' = 'true' to keep the original behavior.

• Assignee: Sai Sharath Dandi
• Reporter: Sai Sharath Dandi
• Created: 13/Dec/23 22:06
• Updated: 26/Feb/24 04:58
• Resolved: 26/Feb/24 04:58

Description

Background

 

The current Protobuf format implementation always sets ReadDefaultValues=False when using Proto3 version. This can cause severe performance degradation for large Protobuf schemas with OneOf fields as the entire generated code needs to be executed during deserialization even when certain fields are not present in the data to be deserialized and all the subsequent nested Fields can be skipped. Proto3 supports hasXXX() methods for checking field presence for non primitive types since Proto version 3.15. In the internal performance benchmarks in our company, we've seen almost 10x difference in performance for one of our real production usecase when allowing to set ReadDefaultValues=False with proto3 version. The exact difference in performance depends on the schema complexity and data payload but we should allow user to set readDefaultValue=False in general.

 

Solution

 

Support using ReadDefaultValues=False when using Proto3 version. We need to be careful to check for field presence only on non-primitive types if ReadDefaultValues is false and version used is Proto3

Issue Links

• links to: GitHub Pull Request #24035