Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-25325 Migration Flink from Junit4 to Junit5
  3. FLINK-33629

Introduce ArchTest rules to ban Junit 4 for modules already completed the migration

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.18.0
    • 1.19.0
    • Tests

    Description

      Currently, many modules have already completed the migration to JUnit 5, and we need to prevent the introduction of JUnit 4 tests in new PRs.

      However, completely removing the dependency on JUnit 4 is challenging. It requires defining JUnit 4 as optional in the flink-parent module and allowing sub-modules to selectively include it. However, this approach still cannot solve the issue of transitive dependencies.

      Therefore, considering introducing new rules in ArchTest to prohibit the usage of JUnit 4 in modules that have already completed the migration.

      Attachments

        Issue Links

          Activity

            People

              jiabao.sun jiabao.sun
              jiabao.sun jiabao.sun
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: