Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-32286

Align the shade pattern that Hive connector using for calcite related class with flink-table-planner

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Connectors / Hive
    • None

    Description

      After FLINK-31413, hive-connector will only have flink-table-calcite-bridge provided dependency and 
      flink-table-planner test dependency. But in flink-table-planner, it'll shade com.google.xx to org.apache.flink.calcite.shaded.com.google.xx.

      Then it'll result in we compile hive-connector against com.google, but actuall run against org.apache.flink.calcite.shaded.com.google provided by flink-table-planner.

      It'll bring much pain while developing hive connector. We may need to introduce a new moulde named flink-hive-table-calcite-bridge to wrap flink-table-calcite-bridge to do same shadding to flink-table-planner, and then make flink-connector dependend on flink-hive-table-calcite-bridge. 

       Remember this should be done after FLINK-30064 in which we'll migrate hive connector to a dedicated repo, and introduce the wrapper module to the dedicated repo.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              luoyuxia luoyuxia
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: