[DRILL-1927] Aggregation or Group-By on a CASE expression with IN subquery fails

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 1.0.0
• Component/s: Query Planning & Optimization
• Assignee: Sean Hsuan-Yi Chu
• Reporter: Aman Sinha
• Created: 05/Jan/15 17:33
• Updated: 02/Jul/15 13:53
• Resolved: 10/May/15 04:28

Description

The following queries fail within Calcite and depend on the fix for CALCITE-516. I am creating a Drill JIRA such that we can add tests with data verification.

select (case when emp.empno in (3) then 0 else 1 end) 
  from emp 
group by (case when emp.empno in (3) then 0 else 1 end);

java.lang.AssertionError: Internal error: while converting CASE WHEN `EMP`.`EMPNO` IN (3) THEN 0 ELSE 1 END
	at org.eigenbase.util.Util.newInternal(Util.java:750)
	at org.eigenbase.sql2rel.ReflectiveConvertletTable$1.convertCall(ReflectiveConvertletTable.java:93)
	at org.eigenbase.sql2rel.SqlNodeToRexConverterImpl.convertCall(SqlNodeToRexConverterImpl.java:52)
	at org.eigenbase.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4093)
	at org.eigenbase.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:1)
	at org.eigenbase.sql.SqlCall.accept(SqlCall.java:125)
	at org.eigenbase.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:3988)
	at org.eigenbase.sql2rel.SqlToRelConverter$AggConverter.addGroupExpr(SqlToRelConverter.java:4314)
	at org.eigenbase.sql2rel.SqlToRelConverter.createAggImpl(SqlToRelConverter.java:2240)
	at org.eigenbase.sql2rel.SqlToRelConverter.convertAgg(SqlToRelConverter.java:2191)
	at org.eigenbase.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:514)
	at org.eigenbase.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:474)

   SELECT SUM(CASE WHEN empno IN (3) THEN 0 ELSE 1 END) FROM emp;

java.lang.AssertionError: Internal error: Identifier 'EMP.EMPNO' is not a group expr
	at org.apache.calcite.util.Util.newInternal(Util.java:727)
	at org.apache.calcite.sql2rel.SqlToRelConverter.convertIdentifier(SqlToRelConverter.java:3307)
	at org.apache.calcite.sql2rel.SqlToRelConverter.access$6(SqlToRelConverter.java:3296)
	at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4299)
	at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:1)
	at org.apache.calcite.sql.SqlIdentifier.accept(SqlIdentifier.java:271)
	at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:4182)
	at org.apache.calcite.sql2rel.SqlToRelConverter.substituteSubquery(SqlToRelConverter.java:979)
	at org.apache.calcite.sql2rel.SqlToRelConverter.replaceSubqueries(SqlToRelConverter.java:937)
	at org.apache.calcite.sql2rel.SqlToRelConverter.createAggImpl(SqlToRelConverter.java:2685)
	at org.apache.calcite.sql2rel.SqlToRelConverter.convertAgg(SqlToRelConverter.java:2525)
	at org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:608)

Issue Links

• depends upon: DRILL-2914 regression: Mondrian query534.q, drill give wrong result