[DERBY-433] Minor code cleanup is needed in NetXAResource

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 10.1.1.0, 10.2.1.6
• Component/s: Network Client
• Assignee: Unassigned
• Reporter: Katherine Marsden
• Created: 02/Jul/05 02:58
• Updated: 23/Feb/06 08:09

Description

These are a few items items that should be cleaned up in NetXAResource and related files. There are surely other items as well.

1) In setXaStateForXAException(int rc), rc codes that do not change the xa state should be verified and checked individually and an assertion thrown for unexpected return codes.

2) Remove infrastructure for chaining xa calls. The client xa implementation used to queue up xa requests and had an assocated callInfoArray, e.g.
// TODO: change to a single callInfo field (not an array)
NetXACallInfo callInfoArray_[] =
new NetXACallInfo[INITIAL_CALLINFO_ELEMENTS];

3)Remove residual code related to making secondary connections for recover.

For example in NetXAResource ..
String rmIdx_; // userid in case we need to create a secondary connection
String rmIdy_; // password in case we need to create a secondary connection
// TODO: remove port and ipaddr_
int port_; // port needed to make secondary connection for recover in DS mode.
String ipaddr_; // ip address needed to make secondary connection for recover in DS mode.

4) eliminate unused fields in NetXAResource, such as activeXATransCount_

Issue Links

• is related to: DERBY-1024 Client's XAResource.start throws XAException with XAER_RMFAIL when local transaction is active