Update demo's to remove references to com.ibm.db2.jcc.DB2Driver

• Key: DERBY-4276
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Lily Wei
• Reporter: Lily Wei
• Component/s: Demos/Scripts
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.2.0, 10.6.0.0

Description

SimpleApp.java is still refering to DB2 JDBC driver. I think it should be take out to reflect DB2 driver is no longer supported.

There are also some typos in SimpleApp.java. i.e. noone, retreiving, etc.

example.html that should be updated as well.

Kathey mention nserverdemo also has references to the DB2 driver. This issue will address that as well.

Comments

[Lily Wei]

I take out the support for DB2 driver in SimpleApp.java including refer to jccjdbcclient as an option of JDBC connection framework.

There are also some typos in SimpleApp.java. i.e. noone, retreiving, etc. Should I open a new issue for typo issue? I just thought I mention it here too.

[Kathey Marsden]

Thank you Lily for looking at this issue.
- There is also a file example.html that should be updated.
- Regarding the typo's I normally say don't combine changes, but I think this is fine to sneak in.
- I noticed nserverdemo also has references to the DB2 driver. Would you like to remove those as well? If so, I think it would be ok to change the summary of this issue to be something more general like "Update demo's to remove references to com.ibm.db2.jcc.DB2Driver" and make those changes under the same issue.

[Lily Wei]

I recompile and run demo for SimpleApp and nserverdemo.
The change for this attempt:
1. Take out all the code and comment relate to DB2 JDBC driver
2. simple/example.html also takes sout reference to DB2 JDBC driver
3. Take out reference to DB2 JDBC driver in nserverdemo/NsSample.java, SimpleNetworkClientSample.java, and nserverdemo/simpleserversample.html,nserverdemo.html
4. Take out reference for NsSampleWork.class from nserverdemo.html

Both simple and nserverdemo has comment refer to jcc for username and password. I am not sure the history with it. I am welcome for any good suggestion.

[Kathey Marsden]

Thank you Lily for the patch. Below are some comments
NsSample.java:
- take out line 45 (default is the derby client JDBC driver) since there is now only one driver possible.
- I think we can just remove parseArguments() since we always run with derby client.
- This is not related to DB2 but would be a good change to make and I think ok to bundle
  user/password from cloud/scape to something like derbyuser/pass

SimpleApp
-noone should be changed to no one or nobody instead of none.
-You changed generics to generic but generics was correct.

SimpleNetworkClientSample
- remove parseArguments since there is just one driver option.
 
example.html
- line 351 remove the word "both"

Regarding the user and password. It would be good to just use something consistent for all the tests like derbyuser/pass.

[Lily Wei]

Thank Kathey for all the good points. I am happy to be part of Derby.

NsSample.java
1. Take out line 45
2. Use user "derbyuser" password "pass"

SimpleNetworkClientSample
1. Remove parseArguments
2. Use user "derbyall" password "pass"

SimpleApp
1. noone is now no one
2. generics it is. English can be so strange to me from time to time. Hope you are smiling now.

examle.html
1. Line 351 does not have both now.

I am not looking at othe demo yet. I will definitely use "derbyuser/pass" on demo.

I rerun both SimpleApp and nserverdemo example. They behave like before. Should I run suites.all and derbyall for this patch?

[Lily Wei]

I just run derbyall and suits.all tests against trunk after the patch. No failure on both suites.

[Lily Wei]

Kathey was so nice to point out I did not do diff from the top. One more try. This one I run test derbyall and suites.all. No failure.

[Kathey Marsden]

Thanks Lily for the patch. I committed to trunk and 10.5.