Remove dependency of junit targets on deprecated jdk16 variable

• Key: DERBY-4022
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Rick Hillegas
• Reporter: Rick Hillegas
• Component/s: Build tools
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.1.1

Description

The junit target for running the jdbc4 tests depends on the jdk16 variable being set in your ant.properties. For the build, this variable has been deprecated. We should be able to make the jdbc4 tests depend on whether the environment is Java 6 instead.

Comments

[Rick Hillegas]

Attaching derby-4022-01-aa-junitVSjdk16.diff. This patch removes the dependency of the junit JDBC4 test target on the deprecated jdk16 variable. Makes the following changes:

1) Removes the final mention of jdk16 in the master build.xml file.

2) Makes the junit-jdbc4 target depend on whether the VM level is at least Java 6.

Note that this involves a behavioral change from the previous situation. Previously, you could run the ant targets in a Java 5 environment and the JDBC4 tests would run (on Java 6) if you set jdk16 correctly. Now you only get the JDBC4 tests if your environment is at least Java 6. This seems like a straightforward solution to deprecating jdk16 and ought to fit the usage of most people. However, it may not fit the usage of some developers. If this is an intolerable change, then we may want to consider preserving the jdk16 variable for use only by the tests.

If this solution does seem acceptable, then we probably need to update the testing documentation to remove references to jdk16.


Touches the following file:

M build.xml

[Rick Hillegas]

If there are no objections to the behavioral change, then I propose to check this in next Tuesday.

[Rick Hillegas]

Committed derby-4022-01-aa-junitVSjdk16.diff at subversion revision 736106.